xiaoping_rubyist (ping)

Udemy 上面好些课程只要 10$.有在上面学习的过得么？讲讲经验

xiaoping_rubyist — Thu, 06 Jul 2017 17:33:01 +0800

一个小错误？

xiaoping_rubyist — Tue, 07 Mar 2017 18:07:46 +0800

rails api 文档一个小错误？

这种代码有什么好的重构方法吗？

xiaoping_rubyist — Thu, 12 Jan 2017 14:48:22 +0800

这种代码有什么好的重构吗？

def _assign_network_from_db
  begin
    @nodes.each do |node_name, node|
      next if node["topology_resource_id"].nil?
      topology_resource            = TopologyResource.find(node["topology_resource_id"])
      @interfaces[node_name].each do |interface_name,interface|
        iface =   topology_resource.topology_resource_interfaces.find_by_name interface_name
        if !iface.nil?
          if !iface.topology_vlan_id.nil?

            # Find the vlan details from DB and set them
            topology_vlan     = TopologyVlan.find(iface.topology_vlan_id)
            vlan              = topology_vlan.vlan
            physnet           = topology_vlan.physnet
            external_network  = topology_vlan.external_network
            if interface["ip"].nil?
              interface["ip"]               = iface.ip
            end
            if interface["network"].nil?
              interface["network"]          = iface.network
            end
            if interface["share_network"].nil?
              interface["vlan"]             = vlan
            end
            interface["physnet"]          = physnet
            interface["external_network"] = external_network
            interface["switch_id"]        = iface.switch_id
            interface["switch_port"]      = iface.switch_port
            topology_vlan.status = 'INUSE'
            topology_vlan.save!

          elsif !iface.nil? && !iface.ip.nil?
            if interface["ip"].nil?
              interface["ip"] = iface.ip
            end
            if interface["network"].nil?
              interface["network"] = iface.network
            end
            interface["skip_network"] = true
          end
        elsif !interface_name.match(/X\d:\d+/i).nil?
          # deal with the subinterface(like: X1:1) of UTM by Rex
          iface_parent_name = interface_name.split(":")[0]
          iface_parent = topology_resource.topology_resource_interfaces.find_by_name iface_parent_name

          vlan_result       =  _get_private_vlan
          vlan              = vlan_result["vlan"]
          physnet           = vlan_result["physnet"]
          external_network  = vlan_result["external_network"]

          interface["physnet"]          = physnet
          interface["external_network"] = external_network
          interface["switch_id"]        = iface_parent.switch_id
          interface["switch_port"]      = iface_parent.switch_port   

          if interface["share_network"].nil? then
            interface["vlan"]             = vlan
          end
        end

        if !interface["remote_node"].nil? && interface["routed_connection"].nil? then
          remote_node_name      = interface["remote_node"]
          remote_interface_name = interface["remote_interface"]
          interface["network"]  = nil if interface["network"].to_s.match(/\d/).nil?
          @interfaces[remote_node_name][remote_interface_name]["network"]          = interface["network"] 
          @interfaces[remote_node_name][remote_interface_name]["vlan"]             = vlan
          @interfaces[remote_node_name][remote_interface_name]["physnet"]          = physnet
          @interfaces[remote_node_name][remote_interface_name]["external_network"] = external_network
        end
      end
    end
  rescue => e
    self.status    = "error"
    self.message   = "Error occured while assigning network details from db. #{e}"
    self.backtrace = e.backtrace
    return
  end
end

出现 503 错误

xiaoping_rubyist — Tue, 03 Jan 2017 09:58:51 +0800

点击 Topic/Wiki/Homeland/招聘出现 503 错误，再点就好了。不知道是啥问题。

如何给对象新增属性？

xiaoping_rubyist — Thu, 03 Nov 2016 11:14:11 +0800

我想在 Model 的实例对象中添加 testbed_name 这个属性。 Model

class Topology < ActiveRecord::Base
  attr_accessor :testbed_name
end

class TopologiesController < ApplicationController
  def show
     @topo = Topology.find(2)
     @topo.testbed_name = "VTB100"

     Rails.logger.info "#{@topo.inspect}"  

   respond_to |format|
       format.html
       format.json { render json: @topology }
   end
   end
end

目前的输出 log 中仍然没有 testbed_name 这个属性，我想把 testbed_name 这个属性加入到@topo里面该怎么做？

修改数据库可以，添加属性。还有其他办法么？

gems.ruby-china.org 连不上

xiaoping_rubyist — Tue, 29 Mar 2016 11:17:21 +0800

Fetching gem metadata from https://gems.ruby-china.org/.Retrying dependency api due to error (2/4): Bundler::HTTPError Network error while fetching https://gems.ruby-china.org/api/v1/dependencies?gems=rails%2Cpg%2Csass-rails%2Cuglifier%2Ccoffee-rails%2Cjquery-rails%2Cturbolinks%2Cjbuilder%2Csdoc%2Cdevise%2Chomeland%2Cfont-awesome-sass-rails%2Cgithub-markup%2Cbyebug%2Cweb-console%2Cspring Retrying dependency api due to error (3/4): Bundler::HTTPError Network error while fetching https://gems.ruby-china.org/api/v1/dependencies?gems=rails%2Cpg%2Csass-rails%2Cuglifier%2Ccoffee-rails%2Cjquery-rails%2Cturbolinks%2Cjbuilder%2Csdoc%2Cdevise%2Chomeland%2Cfont-awesome-sass-rails%2Cgithub-markup%2Cbyebug%2Cweb-console%2Cspring

如题，是啥问题？

微信公众号开发的疑惑

xiaoping_rubyist — Mon, 21 Mar 2016 21:36:39 +0800

初学 rails。想学习下微信公众号开发。在填写公众号开发者资料的时候。要填写域名。我在想难道要因此买域名，买空间，备案？填写 xxx.herokuapp.com 的地址好像不行。谢谢大家。

�Rails 升级遇到的问题。从 3.2.2 到 4.2.5

xiaoping_rubyist — Mon, 14 Mar 2016 17:08:06 +0800

同样的代码在不同的版本里被解析出来的结果为啥不一致呢，同一个数据库，代码都一样，rails 行为不一样。 controller

def index 
    @user = get_user
    @role = get_user_role
    @locations = Location.all.map { |l| l[:locationid] }
    params[:location] = session[:location] if !session[:location].nil?
    unless params[:location].nil? 
      @locations = [Location.where({:name => OSUtils.get_location_name(params[:location])}).first.locationid]
    end
   @topologies = Topology.find(:all, 
         :conditions => ["status != ? AND testbed_id IN (?) AND location_id IN (?)", 
         'TERMINATED', Testbed.where(:tb_type => "OSEXEC").all.map {|t| t.tbid}, @locations ])
end

log in rails 4.2.5

Started GET "/topologies" for 10.103.201.205 at 2016-03-14 15:09:30 +0800
Processing by TopologiesController#index as HTML
  Location Load (333.7ms)  SELECT "location".* FROM "location"
  Location Load (332.6ms)  SELECT  "location".* FROM "location" WHERE "location"."name" = $1  ORDER BY "location"."locationid" ASC LIMIT 1  [["name", "Shanghai"]]
  Testbed Load (672.7ms)  SELECT "testbed".* FROM "testbed" WHERE "testbed"."tb_type" = $1  [["tb_type", "OSEXEC"]]
Completed 404 Not Found in 1682ms (ActiveRecord: 1672.6ms)

ActiveRecord::RecordNotFound (Couldn't find all Topologies with 'topology_id': (all, {:conditions=>["status != ? AND testbed_id IN (?) AND location_id IN (?)", "TERMINATED", [283, 356, 279, 280, 336, 282, 281, 286, 285, 358, 295, 288, 332, 327, 264, 247, 337, 313, 287, 335, 341, 284, 339, 338, 352, 350, 351, 340, 246, 244, 242, 245, 243, 241, 324, 348, 357, 319, 364, 297, 333, 342, 349, 362, 355, 359, 311, 345, 300, 251, 322, 346, 249, 302, 274, 248, 303, 344, 250, 343, 254, 289, 328, 294, 293, 252, 329, 292, 347, 363, 299, 305, 235, 325, 360, 315, 321, 310, 318, 361, 290, 255, 232, 323, 291, 326, 265, 301, 253, 261, 304, 259, 296, 260, 257, 267, 266, 256, 298, 258, 236, 272, 231, 314, 307, 233, 312, 239, 276, 273, 238, 316, 237, 308, 309, 230, 275, 317, 234, 320, 334], [3]]}) (found 0 results, but was looking for 2)):
  app/controllers/topologies_controller.rb:38:in `index'

log in rails 3.2.2

  Location Load (0.4ms)  SELECT "location".* FROM "location"
  Location Load (0.9ms)  SELECT "location".* FROM "location" WHERE "location"."name" = 'Shanghai' LIMIT 1
  Testbed Load (1.3ms)  SELECT "testbed".* FROM "testbed" WHERE "testbed"."tb_type" = 'OSEXEC'
Topology Load (15.3ms)  SELECT "topologies".* FROM "topologies" WHERE (status != 'TERMINATED' AND testbed_id IN (283,356,279,280,336,282,281,286,285,358,295,288,332,327,264,247,337,313,287,335,341,284,339,338,352,350,351,340,246,244,242,245,243,241,324,348,357,319,364,297,333,342,349,362,355,359,311,345,300,251,322,346,249,302,274,248,303,344,250,343,254,289,328,294,293,252,329,292,347,363,299,305,235,325,360,315,321,310,318,361,290,255,232,323,291,326,265,301,253,261,304,259,296,260,257,267,266,256,298,258,236,272,231,314,307,233,312,239,276,273,238,316,237,308,309,230,275,317,234,320,334) AND location_id IN (3))

看了下 3.2 的 log 才是想要的解析行为。这里 4.2.5log 解析出来的结果不对，百思不得其解啊。这是为啥？

How to refactor？

xiaoping_rubyist — Mon, 22 Feb 2016 17:26:47 +0800

最近接触到一个前人留下的一个 rails 项目。controller 里面内容太多，而 model 里面几乎没内容。想正好边学边重构下。下面这个 controller 里面的代码太多。比如：

@topologies = Topology.find(:all, :conditions => ["status != ? AND testbed_id IN (?) AND location_id IN (?) AND username ~* ?", 'TERMINATED', Testbed.where(:tb_type => "OSEXEC").all.map {|t| t.tbid}, @locations, @user ])

是不是应该写成函数添加到 model 里面？但是感觉又有很多的查询条件要传入函数里面，几个表都有关联，该怎么分割？学了小半年 rails 了。还是不怎么熟悉。求指导。而且这个项目写的好简陋，语法什么感觉都不规范，想改造下，目前有觉得能力不够。看 ruby-china 的源代码和这个感觉完全是两个世界。 controller

class TopologiesController < ApplicationController
  before_action :is_user?,  :only => [:index, :test, :visualize, :create, :destroy], :unless => :format_json?
  before_action :is_admin?, :only => [:new, :edit, :update]
  before_action :validate_token, :only => [:create, :destroy, :reboot ]
  def format_json?
    if request.format == 'application/json' then
      return true
    else
      return false
    end
  end
def index 
    @user = get_user
    @role = get_user_role
    @locations = Location.all.map { |l| l[:locationid] }
    params[:location] = session[:location] if !session[:location].nil?
    if !params[:location].nil? then
      @locations = [Location.where({:name => OSUtils.get_location_name(params[:location])}).first.locationid]
    end

    # Filter based on status
    if @role == 'Admin' then
      if params[:status] then
        @topologies = Topology.where({:status => params[:status], :location_id => @locations}).all
      elsif params[:tb_type] && params[:tb_type] == "setup" then
        @topologies = Topology.find(:all, :conditions => ["status != ? AND testbed_id IN (?) AND location_id IN (?)", 'TERMINATED', Testbed.where(:tb_type => "OSSETUP").all.map {|t| t.tbid}, @locations])
      else
        @topologies = Topology.find(:all, :conditions => ["status != ? AND testbed_id IN (?) AND location_id IN (?)", 'TERMINATED', Testbed.where(:tb_type => "OSEXEC").all.map {|t| t.tbid}, @locations ])
      end
    else
      @topologies = Topology.find(:all, :conditions => ["status != ? AND testbed_id IN (?) AND location_id IN (?) AND username ~* ?", 'TERMINATED', Testbed.where(:tb_type => "OSEXEC").all.map {|t| t.tbid}, @locations, @user ])
    end

    # Add testbed name to the records
    @topologies.each do |topology|
      topology["testbed_name"] = Testbed.find(topology.testbed_id).name
    end
    @topologies.sort_by! { |t| t["testbed_name"] }

    respond_to do |format|
      format.html # index.html.erb
      format.json { render json: @topologies }
    end
  end
end

model

class Topology < ActiveRecord::Base
  attr_accessible :hold_time, :location_id, :status, :testbed_id, :topology_definition_resolved, :topology_definition_unresolved, :username, :created_by, :create_at
  validates :status, inclusion: { in: [ "IDLE", "INUSE", "TERMINATED" ] }
end

class Testbed < ActiveRecord::Base
  attr_accessible :alias, :feature_group_id, :location_id, :name, :openstack_status, :platform_group_id, :qbs_server_id, :remark, :status_id, :tb_config, :tb_diagram, :user_group_id, :tb_type, :locked_by

  self.table_name = 'testbed'
  alias_attribute :testbed_id, :tbid
  alias_attribute :qbs_server_id, :qbs_serverid
  alias_attribute :location_id, :locationid
  alias_attribute :user_group_id, :user_groupid
  alias_attribute :status_id, :statusid
  alias_attribute :feature_group_id, :feature_groupid
  alias_attribute :platform_group_id, :platform_groupid

  validates_uniqueness_of :name

  has_many :hosts, :foreign_key => :tbid
end

routes

resources :topologies